Improvement/s3 utils 191 #337
Open
+92
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benzekrimaha
force-pushed
the
improvement/S3UTILS-191
branch
3 times, most recently
from
900271a to
02d89bc
Compare
benzekrimaha
commented
May 6, 2025
| @@ -28,7 +28,7 @@ | |||
| "dependencies": { | |||
| "@senx/warp10": "^2.0.3", | |||
| "JSONStream": "^1.3.5", | |||
| "arsenal": "git+https://github.com/scality/arsenal#8.2.8", | |||
| "arsenal": "git+https://github.com/scality/arsenal#22a5462d7d9bdec0d21a0e9fb484594af35c1cee", | |||
There was a problem hiding this comment.
Please note that this will be switched to the arsenal adequate version once the current in review PR with a fix is merged: scality/Arsenal#2371
benzekrimaha
force-pushed
the
improvement/S3UTILS-171-bump-deps
branch
from
254ba0b to
ba16cc2
Compare
benzekrimaha
force-pushed
the
improvement/S3UTILS-191
branch
from
02d89bc to
3d693cb
Compare
benzekrimaha
force-pushed
the
improvement/S3UTILS-191
branch
from
4fbf388 to
6ca91b6
Compare
williamlardier
approved these changes
May 6, 2025
This commit actually implements the _getIsTransient and _pensieveLocationIsTransient methods in the CountWorker.js previously implemented on arsenal and only used by the CountWorker.js. Issue: S3UTILS-191
benzekrimaha
force-pushed
the
improvement/S3UTILS-191
branch
from
afb8abd to
1c533be
Compare
Base automatically changed from
improvement/S3UTILS-171-bump-deps
to
development/1.16
May 6, 2025 12:40
Hello benzekrimaha,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
| mongoMock.getObjectMDStats.mockImplementationOnce((_a, _b, _c, _d, cb) => cb(null, { value: 42 })); | ||
| w.countItems(bucketInfo, (err, results) => { | ||
| expect(err).toBeNull(); | ||
| expect(results).toEqual({ value: 42 }); | ||
| done(); | ||
| }); | ||
| }); | ||
|
|
||
| test('should use real getIsTransient and not crash', done => { |
There was a problem hiding this comment.
should have at least 2 scenarios, depending on this.client.isLocationTransient (since there are multiple code path).
the point is not just to see that countItems is calling getIsTransient, but really to execute the code in getIsTransient to ensure it will not fail in production... (it may be done though other tests, calling the function directly!)
(alternatively, since we use a wrapper of MongoClient in here: if you add the function there they can be tested in mongoclient tests, and you don't need to change the countWorker tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: S3UTILS-191